refactor(sonar): fix cpp:S5817 - #253
Merged
Merged
Conversation
Adjust const qualifiers in tests: mark helper expectation methods as const in windows tests to match their usage, and modify nonConstMethod in the retry scheduler test to be non-const and clear m_durations (so it mutates state as intended). Affected files: tests/unit/general/test_retry_scheduler.cpp, tests/unit/windows/test_settings_manager_revert.cpp, tests/unit/windows/test_win_display_device_modes.cpp.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 35 35
Lines 2289 2289
Branches 1126 1126
=======================================
Hits 2126 2126
+ Misses 60 42 -18
- Partials 103 121 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix sonar issue cpp:S5817
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage